make partition and tenant this postgreslet is responsible configurable #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change the separator in a zalando postgresql name. - Unify the namespaces of our resources and zalando resources. - Add the flags `partition-id` and `tenant`.
LimKianAn
requested review from
majst01 and
eberlep
and removed request for
majst01
majst01
reviewed
Dec 11, 2020
majst01
changed the title
majst01
requested changes
Dec 11, 2020
|
@majst01 Changes are completed. |
|
@eberlep If everything is alright, please merge it. Thanks! |
eberlep
reviewed
Dec 16, 2020
| return true | ||
| } | ||
|
|
||
| func (r *PostgresReconciler) createZalandoPostgresql(ctx context.Context, z *pg.ZalandoPostgres) (ctrl.Result, error) { | ||
| log := r.Log.WithValues("zalando postgresql", z.ToKey()) | ||
|
|
||
| // todo: Create a ns if none. | ||
| // Make sure the namespace exists in the worker-cluster. // todo: Make sure it happens in the worker-cluster. | ||
| ns := z.Namespace |
There was a problem hiding this comment.
I understand we use the same namespace for the Zanaldo PostgreSQL object as we use for the FI-TS Postgres object here?
If that's the case we might need to discuss this: The FI-TS object resides in our common "seed" cluster, whereas the Zalando object resides in the worker or service cluster. And if I remember correctly, we don't separate the FI-TS objects per tenant/project in the seed cluster, but might have to do so in the service cluster? If so, we cannot use the same namespace but have to separete them?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partition-idandtenant.