implementation of k8s client separation. #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate managers/clients to communicate with the service cluster (which holds the zalando postgresql resources) and the control plane cluster (which holds our fits postgres resources)
eberlep
commented
Dec 16, 2020
| return ctrl.Result{}, err | ||
| } | ||
| log.Info("postgres status updated successfully", "status", newStatus) | ||
| // Update status will be handled by the StatusReconciler, based on the Zalando Status |
There was a problem hiding this comment.
We don't need this part anymore.
eberlep
changed the title
LimKianAn
reviewed
Dec 16, 2020
| @@ -90,12 +112,13 @@ func main() { | |||
| }() | |||
|
|
|||
| if err = (&controllers.PostgresReconciler{ | |||
| Client: mgr.GetClient(), | |||
| Client: ctrlPlaneClusterMgr.GetClient(), | |||
There was a problem hiding this comment.
How about an explicit name like ctrl for the client of the control-plane cluster and another explicit name like svc for the client of the service cluster?
LimKianAn
reviewed
Dec 16, 2020
| Log: ctrl.Log.WithName("controllers").WithName("Status"), | ||
| Scheme: mgr.GetScheme(), | ||
| }).SetupWithManager(mgr); err != nil { | ||
| Client: svcClusterMgr.GetClient(), |
There was a problem hiding this comment.
Like the above. How about an explicit name like svc for the client of the service-cluster?
Separate k8s clients dev
…ervice_cluster_and_ctrl_cluster
eberlep
changed the title
eberlep
deleted the
separate_k8s_clients_for_service_cluster_and_ctrl_cluster
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now use two separate managers/clients to communicate with the service cluster (which holds the zalando postgresql resources) and the control plane cluster (which holds our fits postgres resources).