Cert manager provided tls certs #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* shorten DNS name
* Use (obfuscated) commonName in cert when tls subdomain is configured (and possibly publicly announced)
| @@ -97,13 +97,14 @@ func (r *StatusReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctr | |||
| } | |||
|
|
|||
| log.V(debugLogLevel).Info("updating socket") | |||
| if owner.Spec.DedicatedLoadBalancerIP == nil { | |||
| if !owner.EnableDedicatedSVCLB() { | |||
There was a problem hiding this comment.
In the old code you executed the else block when the value of the IP was an empty string (aka "") now you enter the if block . this one looks more correct. i hope this is compatible with existing specs.
ulrichSchreiner
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using the gardener provided certs via annotations, use a configurable cluster isser.