Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-tsc): sync up runTsc #352

Merged
merged 1 commit into from
Jul 5, 2024
Merged

fix(vue-tsc): sync up runTsc #352

merged 1 commit into from
Jul 5, 2024

Conversation

fi3ework
Copy link
Owner

@fi3ework fi3ework commented Jul 5, 2024

Copy link

changeset-bot bot commented Jul 5, 2024

🦋 Changeset detected

Latest commit: 9b9052e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
vite-plugin-checker Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Jul 5, 2024

Deploy Preview for vite-plugin-checker ready!

Name Link
🔨 Latest commit 9b9052e
🔍 Latest deploy log https://app.netlify.com/sites/vite-plugin-checker/deploys/66880ef10674b20008b37c44
😎 Deploy Preview https://deploy-preview-352--vite-plugin-checker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fi3ework fi3ework merged commit 52423b2 into main Jul 5, 2024
8 checks passed
@so1ve
Copy link
Contributor

so1ve commented Jul 6, 2024

Shall we replace changeExtension as well?

@fi3ework
Copy link
Owner Author

fi3ework commented Jul 6, 2024

@so1ve I'm not sure.Just through the comments "Support for basename.xxx to basename.xxx.d.ts", is it something related to emit .d.ts? Plugin do not need to emit d.ts.

@so1ve
Copy link
Contributor

so1ve commented Jul 8, 2024

@fi3ework Please refer to this issue: vuejs/language-tools#3526. changeExtension will resolve a file to the d.ts file, which may cause inconsistencies between vue-tsc and vite-plugin-checker.

@fi3ework fi3ework deleted the syncup branch July 9, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync volar runTsc changes
2 participants