-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added PDB parameter for maxUnavailable #237
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this mostly looks good. I think it needs some additional logic to make sure maxUnavailable is never equal to or greater than the number of replicas for a deployment.
fiaas_deploy_daemon/deployer/kubernetes/pod_disruption_budget.py
Outdated
Show resolved
Hide resolved
tests/fiaas_deploy_daemon/deployer/kubernetes/test_pod_disruption_budget_deploy.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Our users need a more flexible approach than just a default of 1, so we decided to add the option at least to be able to set the value per namespace.