Drop Python 2.7 support and clean up support code #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrik242
previously approved these changes
Aug 16, 2023
nerhus
reviewed
Aug 16, 2023
docs/source/developer.rst
Outdated
| @@ -70,7 +70,7 @@ Once you have created a class for your API type, some of the fields will refer t | |||
|
|
|||
| .. note:: | |||
|
|
|||
| If the Kubernetes documentation says the type is ``object``, the python type should be ``dict``. If the Kubernetes documentation says the type is ``string``, we use ``six.text_type`` to maintain compatibility with both Python 2 and 3. Most other simple types are obvious. | |||
| If the Kubernetes documentation says the type is ``object``, the python type should be ``dict``. If the Kubernetes documentation says the type is ``string``, we use ``str`` to maintain compatibility with both Python 2 and 3. Most other simple types are obvious. | |||
There was a problem hiding this comment.
I am guessing you can also remove the note about Python 2 vs 3 compat here?
nerhus
previously approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think anything needs Python 2.7 support anymore. If there are, those things should be updated ASAP.