Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix custom types in generic positions in export function signatures #130

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Fix custom types in generic positions in export function signatures #130

merged 1 commit into from
Jul 20, 2022

Conversation

arendjr
Copy link
Contributor

@arendjr arendjr commented Jul 19, 2022 •
edited
Loading

Note this does revert to a string-based approach for generating the Rust wasmer runtime, but it saves a lot of code and duplication.

@arendjr arendjr requested a review from a team as a code owner July 19, 2022 15:03
sagacity
sagacity approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@sagacity sagacity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a big rewrite. Happy to see the code get cleaned up and bugfixed, too.

@arendjr arendjr merged commit 8f4f1db into main Jul 20, 2022
@arendjr arendjr deleted the fix-custom-types-in-export-function-signatures branch July 20, 2022 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagacity sagacity sagacity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arendjr @sagacity