Fix issue with node envs (must explicitly set duplex option on Request constructror)
#152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
commit: |
brettimus
changed the title
duplex option on Request constructror0duplex option on Request constructror)
|
tested by Nele on her/oscar's bun project, where the issue first came up |
brettimus
commented
Aug 19, 2024
brettimus
force-pushed
the
fp-4001-fiberplanehono-otel-breaks-when-running-bun
branch
from
7c9d9e1
to
0696491
Compare
oscarvz
approved these changes
Aug 20, 2024
…e Deno does not like our stackblitz packages
brettimus
force-pushed
the
fp-4001-fiberplanehono-otel-breaks-when-running-bun
branch
from
0696491
to
d2fa57b
Compare
brettimus
deleted the
fp-4001-fiberplanehono-otel-breaks-when-running-bun
branch
flenter
reviewed
Aug 20, 2024
| @@ -660,3 +660,13 @@ function FailedWebsocket() { | |||
| </div> | |||
| ); | |||
| } | |||
|
|
|||
| const safeParseJson = (jsonString: string) => { | |||
There was a problem hiding this comment.
There's already an eerily similar exact same safeParseJson function in src/utils/index.ts. Why not import & use that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alright. So. In environments that use node/undici, we need to conform to specifications APPARENTLY.
The fetch specification is in a weird spot.
Technically, when the body of a
RequestInitis a ReadableStream, you MUST specify the propertyduplex: "half"There will be future support for
duplex: "full", however this is not yet exposed.So really, the only option for
duplexis"half"but we need to use it explicitly for future compatibility.