Sandro hc respect caption #349
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preserves <tfoot> and <caption> tags from the original HTML table in the rendered datatable.
See the following example for a practical use case.
```html
<table id="example-table">
<caption>List of smartphones.</caption>
<thead>
<tr>
<th>Model</th>
<th>Price</th>
</tr>
</thead>
<tbody>
<tr>
<td>iPhone 14</td>
<td>$699</td>
</tr>
<tr>
<td>iPhone 15</td>
<td>$799</td>
</tr>
</tbody>
<tfoot style="font-weight: bold">
<tr>
<td>Total</td>
<td>$1498</td>
</tr>
</tfoot>
</table>
<script>
const dt = new DataTable("example-table", {
// This also works:
// caption: "List of smartphones."
});
</script>
```
…es into SandroHc-respect-caption
|
@SandroHc This is really good. Thanks! Unfortunately running |
…s into SandroHc-respect-caption
|
Thanks for the quick reply! I have fixed the merge conflicts and the failing tests over at #348. Feel free to close this PR, we can fix the conflicts in the other PRs and merge from there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.