Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Build GitHub Pages bundle on-the-fly #350

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Conversation

SandroHc
Copy link
Contributor

@SandroHc SandroHc commented Nov 20, 2023

Builds all the JS and CSS files required for the demo pages in docs.yml via GitHub Actions. Removes the necessity of having the JS bundles at /docs/demos/dist/, as they will be compiled and deployed on every commit to main.

Please confirm that, under Settings > Pages > Build and deployment (https://github.com/fiduswriter/simple-datatables/settings/pages), the "Source" field is set to "GitHub Actions".

I have also checked out package-lock.json to make builds deterministic - building the library now or building it in ten months should generate the same code and dependency tree. (reverted)

Builds all the JS and CSS files required for the demo pages in `gh-pages.yml` via GitHub Actions. Removes the necessity of having the JS bundles at `/docs/demos/dist`, as they will be compiled on every commit to `main`.

Please confirm that, under Settings > Pages > Build and deployment (https://github.com/fiduswriter/simple-datatables/settings/pages), the "Source" field is set to "GitHub Actions".

I have checked out `package-lock.json` to make builds deterministic - building the library now or building it in ten months should generate the same code and dependency tree.
@johanneswilm
Copy link
Member

Hey, in general good, but not so sure about package-lock.json. I like the idea behind it, and a few years ago everyone added them to repos everywhere for the reason you describe. A few months later they were removed again as it turned out it just wasn't very practical and one would usually delete them manually whenever doing a new build.

@SandroHc
Copy link
Contributor Author

Never had issues with it, but sounds like a hassle if I had. I'll revert the package-lock.json changes

@johanneswilm
Copy link
Member

@SandroHc thanks!

@johanneswilm johanneswilm merged commit 989c4d7 into fiduswriter:main Nov 20, 2023
2 checks passed
@SandroHc SandroHc deleted the ci branch November 22, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants