Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ja localization to release/1.6.1 branch #137

Merged
merged 4 commits into from
Jun 18, 2014

Conversation

hkurosawa
Copy link
Contributor

Just created another PR for release/1.6.1 to add Japanese localization.
this should be the base of localization for another languages.

The following PR can be closed if this works. thanks.
#123

fikovnik added a commit that referenced this pull request Jun 18, 2014
Add ja localization to release/1.6.1 branch
@fikovnik fikovnik merged commit 0537eb6 into fikovnik:release/1.6.1 Jun 18, 2014
@fikovnik fikovnik added this to the 1.6.1 milestone Jun 18, 2014
@fikovnik
Copy link
Owner

Amazing! Thanks a lot.

One thing - the MainMenu.xib is not localized, is that correct?

@fikovnik fikovnik mentioned this pull request Jun 18, 2014
@fikovnik
Copy link
Owner

I did a little merge and pushed it back. There is one more string missing:

"AUTHORIZATION_INFORMATIVE_TEXT_10_8" = "ShiftIt needs to be authorized to use an Accessibility Service in order to be able to move and resize application windows.\n\nPlease \"Enable access for assistive devices\" in the System Preferences > Universal Access and then restart ShiftIt.";

Thanks!

@hkurosawa
Copy link
Contributor Author

MainMenu.xib menu item strings (other than the bottommost section) seems to have no need to be localized because it will be substituted by the code within initializeActions_ method in ShiftItAppDelegate class which is already localized by Localizable.strings.

As for "AUTHORIZATION_INFORMATIVE_TEXT_10_8", I'm sorry I missed it, will soon prepare another Pull Request for that fix. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants