-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added code for incremental sizing #32
Conversation
…w size in 5% increments
…ediate succession of each other
…h multiple displays. Changed Wider/Taller hotkeys to Increase/Reduce 5% hotkeys
…n issues that created some strange behavior
Thanks! Good idea the anchored resizing. I integrated the code into the The next whole week I do not have an access to external screen, so I won't be making any release. |
Looks good to me. Though this math is making my brain tie itself into a knot: EqualWithVicinity(a,b,e) ((a) >= ((b) - (e)) && (a) <= ((b) + (e))) I'm just gonna have to trust that it's correct-- hahaha |
Wow I just noticed you added support for incremental sizing when the window is pushed to the corners of the screen. Nice touch! |
I have just tested your new code structure for incremental sizing with 2 displays and it appears that the old bug has been fixed. Nice work ;) |
There is one more thing I need to do - properly readjust apps like terminal so they are well anchored. I will then ask you to take it for a spin and then if works ok I'll make a new release. Btw: really good idea with this way of resizing windows! |
The code is in |
I love it :) Although I seem to be getting more desirable behavior after disabling the "margins" that you added for anchoring the window. With margins enabled, some windows would anchor to the opposing side if you expanded too far. Otherwise, works great! I'll test it with multiple monitors at work tomorrow. |
I also have a bit of mixed feelings about the margins. The fact that the window would eventually anchor to the opposing side is actually correct (whether it does any good is another question :) ). When a window is in a margin zone its kind of locked. I added this mostly to fix the problem with terminal and other non-continuosly sizing apps. Perhaps it should be disabled by default? |
I think I prefer it without the margins... Even on apps like the Terminal. Perhaps you should disable it by default. |
You are right. I will disable it by default. |
Right now it changes in increments of 1/12th of the screen (we could eventually make this user configurable). This uses only 2 hotkeys for increase and decrease-- it recognizes which side of the screen the window is touching and it will expand and contract away from that side.
I believe there might be a bug with incremental sizing on secondary monitors but I haven't been able to test this thoroughly.