Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update laravel icon #6

Closed
wants to merge 2 commits into from
Closed

update laravel icon #6

wants to merge 2 commits into from

Conversation

kennith
Copy link

@kennith kennith commented Dec 18, 2020

Thank you for the package. It's great.

I am not sure how to contribute or if you are accepting contribution. I just want to point out that the Laravel icon is outdated.

The new icons are here:
https://github.com/laravel/art/tree/master/logo-mark/5%20svg

If this PR is not correct, please let me know the correct way to submit icon update.

@Alhadis
Copy link
Member

Alhadis commented Dec 23, 2020

Hey mate, thanks for the pull-request and kind words. 👋

This should really have been submitted to file-icons/icons, which is the canonical repository for new icons. DevOpicons (and its sister font, MFixx are kept for backward compatibility reasons only. Ideally, everything would be stored together in one large super-font, but because of conflicting codepoint ranges, this simply isn't possible.

You had no way of knowing any of this, so it's not your fault. 👍 The procedure for adding new icons is currently sticky and complicated, and I'm quite literally in the middle of rehauling it (although it's been nearly a month since I started… 🤔 I really need to commit my damn progress).

In any case, I've added the updated Laravel icon in file-icons/icons@bba1747; you'll see it in the next release (which might be take a while, given the state of things…)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants