Add support .wix files #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alhadis
requested changes
Jan 16, 2020
There was a problem hiding this comment.
For a start, this needs to be submitted to file-icons/atom, as that's (currently) the definitive source of all filetype-to-icon mappings (see the config.cson file in said repository).
Second, it'll still be a while until .wix appears in a package release, because we avoid releasing too often (especially when only negligible changes have been made; users get annoyed if they have to download too many updates).
Third, you shouldn't modify these files directly, but add missing extensions to the import script. That's only for "problematic" extensions, though, and something usually left to maintainers.
|
I got it. Thanks! |
Alhadis
pushed a commit
to file-icons/atom
that referenced
this pull request
Jan 21, 2020
References: file-icons/vscode#49
Alhadis
approved these changes
Jan 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My issue #48