FIP-0041: Forward Compatibility for PreCommit and ReplicaUpdate #395
Conversation
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Kubuxu
requested review from
momack2,
arajasek,
jennijuju,
kaitlin-beegle and
anorth
as code owners
FIPS/fip-xxxx-synthetic-porep.md
Outdated
| When there is a necessary change in parameters of an actor's method exposed to users, the cleanest mechanism to execute such change is to add a new method and permissively continue to accept calls to the old method. | ||
| This mechanism increases implementation complexity as old code pathways have to continue functioning. | ||
| In this case, the motivating factors for the change are User Deployable Storage Markets and FVM Programmability. These two, by themselves, will be complex changes to built-in actors. | ||
| By introducing new method signatures before behavioural changes, the primary change can omit compatibility with old method signatures and thus reduce their complexity and work required. |
There was a problem hiding this comment.
I suggest explicitly stating that we expect the existing methods to be deprecated by the changes described in #298, because that flow will require the unsealed sector CID commitment at pre-commit. Adding the new ones now provides a long period for operators to upgrade.
There was a problem hiding this comment.
e expect the existing methods to be deprecated by the changes described in #298
flag that 298 is a pre-FIP discussion for now ( not certain if the FIP will be accepted later, even though there is a high chance based on the discussion, but it's still a TBD. so I won't recommend adding that explicit statement unless necessary.
FIPS/fip-xxxx-synthetic-porep.md
Outdated
|
|
||
| ## Test Cases | ||
| <!--Test cases for an implementation are mandatory for FIPs that are affecting consensus changes. Other FIPs can choose to include links to test cases if applicable.--> | ||
| Test cases for an implementation are mandatory for FIPs that are affecting consensus changes. Other FIPs can choose to include links to test cases if applicable. |
FIPS/fip-xxxx-synthetic-porep.md
Outdated
| @@ -0,0 +1,114 @@ | |||
| --- | |||
| fip: <to be assigned> | |||
There was a problem hiding this comment.
@kaitlin-beegle can we allocate FIP-0039 FIP-0041?
|
draft looks good, questions & concerns w.r.t tech details & more context can be requested & discussed in #380, and are expected to be addressed by authors before the FIP moves to "Last Call" or being considered to be "Accpeted" |
jennijuju
changed the title
#380