-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIP-0086: Using max ticket #987
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
72e0487
FIP-0086 Propagate some implementation decisions back to the spec.
anorth 6b25bc6
Removed weak quorum
anorth eb13a13
Review responses.
anorth f3e8733
Update valid(m) function
ranchalp 7de7bba
Update fip-0086.md
ranchalp d91afeb
First round of changes from Guy's first Audit
ranchalp e27cfa4
Merge branch 'master' into ranchalp-audit-1
ranchalp 61d48e5
Update GossiPBFT Pseudocode (TODO still update line numbering and oth…
ranchalp 9b26e5e
Update references to line numbers
ranchalp 24f6327
Fix typos (code statements, indenting)
ranchalp 56c8106
Fix valid(m) and validEvidence(m)
ranchalp c6e32b4
Fix DECIDE format
ranchalp 2974f70
Update fip-0086.md
ranchalp b9c1db2
Changes from 2nd audit by Guy
ranchalp 5dab603
Make C a globally scoped variable and update line numbering
ranchalp 57f13f8
Small fix
ranchalp 1fcce20
Fix couple comments
ranchalp 4113980
Merge branch 'master' into ranchalp-audit-1
ranchalp daccc3f
Typos and indentation fixes
ranchalp 417e229
Update to use greatest ticket and adjust by power
ranchalp e03abda
Specify no need to store equivocating messages.
ranchalp c94cb2a
Merge branch 'master' into using-max-ticket
ranchalp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given this is a spec, I don't think we should refer to "the version proposed in this document" or things like that.