-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: blstrs backend and optimized proving #116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went over changes with @dignifiedquire and @porcuquine. Seem completely fine - a straightforward paralellization when possible of group operations.
There is a clash with the dummy engine implementation, but it has to do with the dummy engine using vector inner product as a miller loop, which is not really a miller loop - as it doesn't have the property in particular that e(ML(A,B)*ML(C,D)) = e(A,B)*e(C,D) where e is the pairing and ML is the miller loop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on discussion with @arielgabizon and on @dignifiedquire's reversion of the change to the DummyEngine
implementation, I approve. Let's create an issue to make sure we follow up with a clear fix to that test eventually.
cfc240c
to
31790e0
Compare
31790e0
to
e692286
Compare
Is this CI failure an expected CI timeout where we could extend the test run time or a real bug holding up this work? |
No, we need to sort out what is happening. I'm looking into it but don't have an answer or fix yet. |
Uses https://github.com/dignifiedquire/blstrs to provide a
pairing
alternative backed byblst
.Also integrates the optimizations done in https://github.com/filecoin-project/fil-blst/