groth16 prover: improve param loading #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dignifiedquire
force-pushed
the
perf-param-loading
branch
from
8b176ce
to
231802a
Compare
This was referenced Sep 7, 2021
dignifiedquire
force-pushed
the
perf-param-loading
branch
2 times, most recently
from
efc916a
to
d80ccc1
Compare
vmx
reviewed
Sep 23, 2021
src/groth16/prover.rs
Outdated
Comment on lines
340
to
351
| THREAD_POOL.scoped(|s| { | ||
| let a_s = &mut a_s; | ||
| s.execute(move || { | ||
| let mut fft_kern = Some(LockedFFTKernel::<E>::new(log_d, priority)); | ||
|
|
||
| drop(fft_kern); | ||
| let mut multiexp_kern = Some(LockedMultiexpKernel::<E>::new(log_d, priority)); | ||
| for prover in provers_ref { | ||
| a_s.push(execute_fft(worker, prover, &mut fft_kern)); | ||
| } | ||
| }); | ||
|
|
||
| debug!("get h"); | ||
| params_h = Some(params.get_h(n)); |
There was a problem hiding this comment.
In this case you do the kernel creation and the parameter loading in parallel. You spawn the kernel creation into a new thread, but you wait until both are finished. In the code below, you spawn the parameter generation and do something else on the main thread. Would it make sense (for consistency, and easier to follow code) to change this part to also spawn the parameter generation and leave the kernel generation on the main thread?
dignifiedquire
force-pushed
the
perf-param-loading
branch
from
d80ccc1
to
27fa9a4
Compare
cryptonemo
previously approved these changes
Sep 27, 2021
dignifiedquire
force-pushed
the
perf-param-loading
branch
from
27fa9a4
to
f8efb85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified version of #214