feat: index ad removal command #1859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nonsense
reviewed
Jan 8, 2024
api/api.go
Outdated
| @@ -41,6 +41,8 @@ type Boost interface { | |||
| BoostDeal(ctx context.Context, dealUuid uuid.UUID) (*smtypes.ProviderDealState, error) //perm:admin | |||
| BoostDealBySignedProposalCid(ctx context.Context, proposalCid cid.Cid) (*smtypes.ProviderDealState, error) //perm:admin | |||
| BoostDummyDeal(context.Context, smtypes.DealParams) (*ProviderDealRejectionInfo, error) //perm:admin | |||
| BoostIndexerAnnounceDealRemoved(ctx context.Context, pieceCid cid.Cid) (cid.Cid, error) //perm:admin | |||
| LegacyDealByProposalCid(ctx context.Context, propCid cid.Cid) (storagemarket.MinerDeal, error) //perm:admin | |||
There was a problem hiding this comment.
This is added under Boost MethodGroup, so maybe add Boost prefix?
There was a problem hiding this comment.
Updated. The reason to have it under Boost group is ensure compatibility after removing legacy markets.
nonsense
reviewed
Jan 8, 2024
| @@ -454,6 +458,17 @@ func (s *BoostStub) BoostIndexerAnnounceAllDeals(p0 context.Context) error { | |||
| return ErrNotSupported | |||
| } | |||
|
|
|||
| func (s *BoostStruct) BoostIndexerAnnounceDealRemoved(p0 context.Context, p1 cid.Cid) (cid.Cid, error) { | |||
| if s.Internal.BoostIndexerAnnounceDealRemoved == nil { | |||
| return *new(cid.Cid), ErrNotSupported | |||
There was a problem hiding this comment.
I think you can just use cid.Undef instead of *new(cid.Cid)
There was a problem hiding this comment.
This is auto generated by the make gen. We might have to adjust the types in api gen for this. I am not sure if it is worth the required changes.
There was a problem hiding this comment.
Yes, sorry, didn't notice this is the auto-generated part of the API.
nonsense
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This command will send an ad to IPNI to remove the indexes for a particular deal. This command is to be used for removing deals not being cleaned up by automated system in Boost.