Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update backup command to include new config directory #625

Merged
merged 4 commits into from
Jun 30, 2022
Merged

update backup command to include new config directory #625

merged 4 commits into from
Jun 30, 2022

Conversation

LexLuthr
Copy link
Collaborator

No description provided.

@LexLuthr LexLuthr marked this pull request as ready for review June 28, 2022 18:52
@LexLuthr LexLuthr requested a review from dirkmc June 28, 2022 18:52
LexLuthr
LexLuthr commented Jun 28, 2022
View reviewed changes
cmd/boostd/backup.go Outdated Show resolved Hide resolved
dirkmc
dirkmc reviewed Jun 29, 2022
View reviewed changes
Copy link
Contributor

@dirkmc dirkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this PR together 🙏
Looks good so far - just one suggestion

cmd/boostd/backup.go Outdated Show resolved Hide resolved
@LexLuthr LexLuthr requested a review from dirkmc June 29, 2022 16:04
dirkmc
dirkmc reviewed Jun 30, 2022
View reviewed changes
cmd/boostd/backup.go Outdated Show resolved Hide resolved
@LexLuthr LexLuthr merged commit 0ed2710 into main Jun 30, 2022
@LexLuthr LexLuthr deleted the feat/update-backup branch June 30, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirkmc dirkmc dirkmc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LexLuthr @dirkmc