fix test compilation errors and clippy warnings.

actors/evm/Cargo.toml

@@ -42,6 +42,8 @@ hex = "0.4.3"
 
 [dev-dependencies]
 fil_actors_runtime = { path = "../../runtime", features = ["test_utils", "sector-default"] }
+libsecp256k1 = { version = "0.7.0", features = ["static-context"] }
+hex-literal = "0.3.4"
 
 [features]
 fil-actor = ["fil_actors_runtime/fil-actor"]

actors/evm/src/interpreter/execution.rs

@@ -109,12 +109,12 @@ pub fn execute<'r, BS: Blockstore, RT: Runtime<BS>>(
             OpCode::MSTORE => memory::mstore(runtime)?,
             OpCode::MSTORE8 => memory::mstore8(runtime)?,
             OpCode::JUMP => {
-                pc = control::jump(&mut runtime.stack, &bytecode)?;
+                pc = control::jump(&mut runtime.stack, bytecode)?;
                 continue; // don't increment PC after the jump
             }
             OpCode::JUMPI => {
                 // conditional jump
-                if let Some(dest) = control::jumpi(&mut runtime.stack, &bytecode)? {
+                if let Some(dest) = control::jumpi(&mut runtime.stack, bytecode)? {
                     pc = dest; // condition met, set program counter
                     continue; // don't increment PC after jump
                 }

actors/evm/src/interpreter/instructions/bitwise.rs

@@ -33,7 +33,7 @@ pub fn shl(stack: &mut Stack) {
     if *value == U256::zero() || shift >= U256::from(256) {
         *value = U256::zero();
     } else {
-        *value <<= U256::from(shift)
+        *value <<= shift
     };
 }
 
@@ -45,7 +45,7 @@ pub fn shr(stack: &mut Stack) {
     if *value == U256::zero() || shift >= U256::from(256) {
         *value = U256::zero()
     } else {
-        *value >>= U256::from(shift)
+        *value >>= shift
     };
 }
 
@@ -80,7 +80,7 @@ pub fn sar(stack: &mut Stack) {
 
 #[cfg(test)]
 mod tests {
-    use {super::*, crate::uints::u128_words_to_u256};
+    use {super::*, crate::interpreter::uints::u128_words_to_u256};
 
     #[test]
     fn test_instruction_byte() {

actors/evm/src/interpreter/system.rs

@@ -38,7 +38,7 @@ pub struct System<'r, BS: Blockstore, RT: Runtime<BS>> {
 
 impl<'r, BS: Blockstore, RT: Runtime<BS>> System<'r, BS, RT> {
     pub fn new(rt: &'r RT, state_cid: Cid) -> anyhow::Result<Self> {
-        Ok(Self { rt: rt, state: RefCell::new(Hamt::load(&state_cid, rt.store())?) })
+        Ok(Self { rt, state: RefCell::new(Hamt::load(&state_cid, rt.store())?) })
     }
 
     pub fn flush_state(&self) -> Result<Cid, ActorError> {

actors/evm/src/interpreter/transaction.rs

@@ -570,7 +570,7 @@ impl Debug for Transaction {
 #[cfg(test)]
 mod tests {
     use {
-        crate::{
+        crate::interpreter::{
             transaction::{AccessListItem, Transaction, TransactionAction},
             SignedTransaction, H160, H256, U256,
         },
@@ -641,7 +641,7 @@ mod tests {
                 &input
             );
         } else {
-            assert!(false, "decoded into wrong transaction type");
+            panic!("decoded into wrong transaction type");
         }
     }
 
@@ -719,7 +719,7 @@ mod tests {
                 access_list
             )
         } else {
-            assert!(false, "decoded into wrong transaction type");
+            panic!("decoded into wrong transaction type");
         }
     }
 
@@ -779,7 +779,7 @@ mod tests {
                 action
             );
         } else {
-            assert!(false, "decoded into wrong transaction type");
+            panic!("decoded into wrong transaction type");
         }
     }
 }

actors/evm/src/interpreter/uints.rs

@@ -1,4 +1,9 @@
 #![allow(dead_code)]
+
+// to silence construct_uint! clippy warnings
+// see https://github.com/paritytech/parity-common/issues/660
+#![allow(clippy::ptr_offset_with_cast,clippy::assign_op_pattern)]
+
 use {
     fixed_hash::construct_fixed_hash,
     impl_serde::{impl_fixed_hash_serde, impl_uint_serde},

actors/evm/src/lib.rs

@@ -78,7 +78,7 @@ impl EvmRuntimeActor {
         {
             // constructor ran to completion successfully and returned
             // the resulting bytecode.
-            let contract_bytecode = exec_status.output_data.clone();
+            let contract_bytecode = exec_status.output_data;
 
             let contract_state_cid = system.flush_state()?;