Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve dispatch macro #1088

Merged
merged 1 commit into from
Jan 20, 2023
Merged

feat: improve dispatch macro #1088

merged 1 commit into from
Jan 20, 2023

Conversation

Stebalien
Copy link
Member

  1. Use absolute paths so we don't have to import things everywhere.
  2. Support dispatch fallbacks (_).
  3. Support dispatching to methods without decoding/encoding ([raw]).

@Stebalien Stebalien force-pushed the steb/dispatch-macro-improve branch 3 times, most recently from 6a27c16 to 0fa5789 Compare January 20, 2023 22:49
1. Use absolute paths so we don't have to import things everywhere.
2. Support dispatch fallbacks (`_`).
3. Support dispatching to methods without decoding/encoding (`[raw]`).
@Stebalien Stebalien force-pushed the steb/dispatch-macro-improve branch from 0fa5789 to 5cf5cfb Compare January 20, 2023 22:49
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, appease Clippy.

@Stebalien
Copy link
Member Author

Clippy has been appeased (finally)

@Stebalien Stebalien merged commit dfe0676 into master Jan 20, 2023
@Stebalien Stebalien deleted the steb/dispatch-macro-improve branch January 20, 2023 23:10
@arajasek
Copy link
Contributor

Clippy has been appeased (finally)

...for now.

shamb0 pushed a commit to shamb0/builtin-actors that referenced this pull request Jan 31, 2023
1. Use absolute paths so we don't have to import things everywhere.
2. Support dispatch fallbacks (`_`).
3. Support dispatching to methods without decoding/encoding (`[raw]`).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants