Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Feature: move partition (#1326)" from nv12 #1481

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Revert "Feature: move partition (#1326)" from nv12 #1481

merged 3 commits into from
Nov 14, 2023

Conversation

aarshkshah1992
Copy link
Contributor

Reverts #1326 from NV12.

@aarshkshah1992 aarshkshah1992 changed the base branch from master to release/v12 November 10, 2023 05:56
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release/v12@b188744). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##             release/v12    #1481   +/-   ##
==============================================
  Coverage               ?   91.16%           
==============================================
  Files                  ?      145           
  Lines                  ?    27540           
  Branches               ?        0           
==============================================
  Hits                   ?    25107           
  Misses                 ?     2433           
  Partials               ?        0

@aarshkshah1992 aarshkshah1992 mentioned this pull request Nov 10, 2023
Merged
13 tasks
@arajasek
Copy link
Contributor

Note: We would land this if we decide to descope FIP-0070 from nv21 due to a bug in the current actors code.

@arajasek
Copy link
Contributor

Landing as this FIP will be descoped from v12 actors (detailed announcement to come from @luckyparadise)

@arajasek arajasek merged commit 1b8c528 into release/v12 Nov 14, 2023
15 checks passed
@arajasek arajasek deleted the feat/revert-move-partitions-1326-nv12 branch November 14, 2023 15:13
@arajasek arajasek mentioned this pull request Nov 14, 2023
Merged
arajasek pushed a commit that referenced this pull request Nov 14, 2023
@aarshkshah1992 @arajasek
Revert "Feature: move partition (#1326)" from nv12 (#1481)
de366e3 
* Revert "Feature: move partition  (#1326)"

This reverts commit 5ec2a6b.

* ci

* run CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arajasek arajasek arajasek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aarshkshah1992 @codecov-commenter @arajasek