Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add devnet-wasm and wallaby networks with associated features to build scripts #504

Merged
merged 9 commits into from
Jul 28, 2022

Conversation

raulk
Copy link
Member

@raulk raulk commented Jul 27, 2022

  • wallaby is a new shared testnet mimicking butterfly, with Wasm actor deployment enabled.
  • devnet-wasm is the bundle to be used in devnets / localnets, with Wasm actor deployment enabled.

@raulk
Copy link
Member Author

raulk commented Jul 28, 2022

This doesn't work when building the devnet-m2-native bundle because of a tricky circumstance.

  • This adds a new "network" devnet-m2-native.
  • The runtime/build.rs build script is adjusted to enable the m2-native feature.
  • The runtime/Cargo.toml defines the m2-native feature such that it also enables the m2-native feature in the fvm_sdk dependency.

Unfortunately, this doesn't work because build scripts are run after dependency resolution, as indicated by the Build Scripts docs:

Note that this does not affect Cargo's dependency resolution. This cannot be used to enable an optional dependency, or enable other Cargo features.

This issue explains more: rust-lang/cargo#5499

@raulk raulk force-pushed the next-m2-native-bundle branch from 80411ce to a515158 Compare July 28, 2022 14:01
QoL finishing touches:
- The 1:N network/features mapping in runtime/build.rs wasn't cutting it any longer.
  I expanded this data structure to M:N.
- Added docs to runtime/build.rs.
@raulk raulk force-pushed the next-m2-native-bundle branch from a515158 to 5f76d96 Compare July 28, 2022 14:03
@raulk raulk changed the title add devnet-m2-native network with associated features to build scripts add devnet-wasm and wallaby networks with associated features to build scripts Jul 28, 2022
@raulk raulk merged commit 427bc99 into next Jul 28, 2022
@raulk raulk deleted the next-m2-native-bundle branch July 28, 2022 14:14
shamb0 pushed a commit to shamb0/builtin-actors that referenced this pull request Oct 3, 2022
…d scripts (filecoin-project#504)

* add devnet-m2-native network with associated features to build scripts

* transitively activate m2-native on runtime

* add devnet-m2-native bundle build target

* fix output target for m2-native bundle

* pacify clippy.

* runtime: Cargo.toml sort dependencies.

* Cargo.toml: point patches to master.

* fix devnet-m2-bundle by propagating Cargo features.

* add build preset / bundle configurations for wallaby and devnet-wasm.

QoL finishing touches:
- The 1:N network/features mapping in runtime/build.rs wasn't cutting it any longer.
  I expanded this data structure to M:N.
- Added docs to runtime/build.rs.

Co-authored-by: vyzo <vyzo@hackzen.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants