Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Sectors table dropdowns #125

Merged
merged 7 commits into from
Aug 6, 2024
Merged

feat: Sectors table dropdowns #125

merged 7 commits into from
Aug 6, 2024

Conversation

snadrus
Copy link
Contributor

@snadrus snadrus commented Jul 26, 2024 •
edited
Loading

Web basic things:

  • Sectors filtering
  • request & jsonRPC logging

Screenshot 2024-07-31 at 4 52 12 PM

@snadrus snadrus marked this pull request as ready for review July 31, 2024 22:32
@snadrus snadrus changed the title WIP: Improving filtering on Sectors Datatable feat: Sectors table dropdowns Jul 31, 2024
@snadrus
Copy link
Contributor Author

snadrus commented Jul 31, 2024

All except deal*, sector, and expiry have dropdowns

@snadrus snadrus requested a review from LexLuthr July 31, 2024 22:34
LexLuthr
LexLuthr approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@LexLuthr LexLuthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Looks good.

@LexLuthr LexLuthr merged commit 8728293 into main Aug 6, 2024
7 checks passed
@LexLuthr LexLuthr deleted the feat/web-sel-miner branch August 6, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LexLuthr LexLuthr LexLuthr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snadrus @LexLuthr