Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not use miner config for harmonyDB #153

Merged
merged 1 commit into from
Aug 19, 2024
Merged

fix: do not use miner config for harmonyDB #153

merged 1 commit into from
Aug 19, 2024

Conversation

LexLuthr
Copy link
Contributor

No description provided.

@LexLuthr LexLuthr marked this pull request as ready for review August 15, 2024 13:23
@LexLuthr LexLuthr changed the title fix: do not miner config for harmonyDB fix: do not use miner config for harmonyDB Aug 16, 2024
magik6k
magik6k approved these changes Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, users still need to attach all paths to curio, so the sector index will be migrated. Simpler = better.

Feel free to merge if you gave this a try and it seems to work.

@LexLuthr
Copy link
Contributor Author

Tested it in devnet and it works.

@LexLuthr LexLuthr merged commit 45373f7 into main Aug 19, 2024
7 checks passed
@LexLuthr LexLuthr deleted the fix/guided-setup branch August 19, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

@snadrus snadrus Awaiting requested review from snadrus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LexLuthr @magik6k