Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: synthetic PoRep #58

Merged
merged 12 commits into from
Jul 25, 2024
Merged

feat: synthetic PoRep #58

merged 12 commits into from
Jul 25, 2024

Conversation

LexLuthr
Copy link
Contributor

@LexLuthr LexLuthr commented Jun 13, 2024 •
edited
Loading

No description provided.

@LexLuthr LexLuthr changed the title feat: synthetic PoRep [WIP] feat: synthetic PoRep Jun 13, 2024
@LexLuthr LexLuthr requested review from magik6k and snadrus June 17, 2024 13:54
@LexLuthr LexLuthr changed the title [WIP] feat: synthetic PoRep feat: synthetic PoRep Jun 17, 2024
@LexLuthr LexLuthr changed the title feat: synthetic PoRep [WIP] feat: synthetic PoRep Jun 17, 2024
@LexLuthr
Copy link
Contributor Author

@magik6k Should we provide Max task value in config for Synth tasks or an internal 50 would be good enough?

magik6k
magik6k reviewed Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments, looks great overall!

cmd/curio/tasks/tasks.go Outdated Show resolved Hide resolved
lib/ffi/sdr_funcs.go Outdated Show resolved Hide resolved
lib/ffi/sdr_funcs.go Outdated Show resolved Hide resolved
lib/ffi/sdr_funcs.go Outdated Show resolved Hide resolved
tasks/seal/task_synth_proofs.go Outdated Show resolved Hide resolved
@LexLuthr LexLuthr requested a review from magik6k July 22, 2024 11:25
@LexLuthr LexLuthr changed the title [WIP] feat: synthetic PoRep feat: synthetic PoRep Jul 22, 2024
magik6k
magik6k reviewed Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI seems sad + a few comments, but this looks really good already

tasks/seal/task_sdr.go Outdated Show resolved Hide resolved
lib/ffi/sdr_funcs.go Show resolved Hide resolved
@filecoin-project filecoin-project deleted a comment from magik6k Jul 22, 2024
@LexLuthr LexLuthr requested a review from magik6k July 22, 2024 15:37
@magik6k magik6k merged commit d3f8f10 into main Jul 25, 2024
8 checks passed
@magik6k magik6k deleted the feat/synthetic-proofs branch July 25, 2024 20:09
@LexLuthr LexLuthr mentioned this pull request Oct 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

@snadrus snadrus Awaiting requested review from snadrus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LexLuthr @magik6k