Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FFISelect improvements #70

Merged
merged 2 commits into from
Jun 26, 2024
Merged

FFISelect improvements #70

merged 2 commits into from
Jun 26, 2024

Conversation

snadrus
Copy link
Contributor

@snadrus snadrus commented Jun 26, 2024

Change:
Whenever we see <2 GPUs, we just do a call locally.

Reasoning:

  • I'm unsure why we saw recursion, but this should resolve it because the subsequent depth will only see 1 GPU.
  • Performance improvement for machines with 1 card
  • It implicitly supports the 0 GPU "dev-net" case.

@snadrus snadrus requested a review from LexLuthr June 26, 2024 05:25
@snadrus snadrus requested a review from magik6k June 26, 2024 05:37
@snadrus snadrus merged commit 2b4ed70 into main Jun 26, 2024
6 checks passed
@snadrus snadrus deleted the ffiselect-inf-loop branch June 26, 2024 14:25
magik6k added a commit that referenced this pull request Jul 2, 2024
@magik6k
Revert "FFISelect improvements (#70)"
9f52da1 
This reverts commit 2b4ed70.
@magik6k magik6k mentioned this pull request Jul 2, 2024
Merged
magik6k added a commit that referenced this pull request Jul 8, 2024
@magik6k
Revert "FFISelect improvements (#70)" (#78)
bba6ddf 
This reverts commit 2b4ed70.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LexLuthr LexLuthr LexLuthr approved these changes

@magik6k magik6k Awaiting requested review from magik6k

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snadrus @LexLuthr