Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vyzo's review of the dagstore #93

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

vyzo's review of the dagstore #93

wants to merge 1 commit into from

Conversation

vyzo
Copy link

@vyzo vyzo commented Aug 2, 2021

Haven't dived into the subdirectories yet.

@vyzo vyzo requested a review from raulk August 2, 2021 11:54
@vyzo
Copy link
Author

vyzo commented Aug 2, 2021

So far one minor bug (see comments inline) and one recommendation for refactoring:
The task processing logic of the event loop should be extracted on its own method, which can then:

  • lock/defer unlock to avoid having a really long lock scope with a bunch of pasta in-between
  • return the next task and avoid the internaclCh indirection, which can now be removed altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant