feat: add option to not require a t_aux file to be present #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
vmx
force-pushed
the
fixed-rows-to-discard
branch
from
1c4bb87
to
aecf491
Compare
The `FFI_USE_FIXED_ROWS_TO_DISCARD` variable will make the proofs ignore the `FIL_PROOFS_ROWS_TO_DISCARD` setting, hence not relying on a `t_aux` file to be present. If enabled, then no `t_aux` file will be written by the proofs and a hard-coded value for `FIL_PROOFS_ROWS_TO_DISCARD` will be used.
vmx
force-pushed
the
fixed-rows-to-discard
branch
from
aecf491
to
8bf8a4f
Compare
cryptonemo
approved these changes
Nov 8, 2023
|
As we now have confirmed that SupraSeal PC2 works with filecoin-project/lotus#11185 (comment), and this latest proofs-version I think we can merge this and bubble it up to Lotus. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
FFI_USE_FIXED_ROWS_TO_DISCARDvariable will make the proofs ignore theFIL_PROOFS_ROWS_TO_DISCARDsetting, hence not relying on at_auxfile to be present. If enabled, then not_auxfile will be written by the proofs and a hard-coded value forFIL_PROOFS_ROWS_TO_DISCARDwill be used.I make this into draft mode as CI currently isn't passing due to #431.