explicitly close os.File to force release of file descriptor #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laser
changed the title
sbwtw
pushed a commit
to sbwtw/filecoin-ffi
that referenced
this pull request
Jun 19, 2020
…n-project#97) * fix: affirm that we don't run out of file descriptors * be sure to close file instead of waiting for GC
gracenoah
pushed a commit
to gracenoah/filecoin-ffi
that referenced
this pull request
Dec 20, 2020
…n-project#97) * fix: affirm that we don't run out of file descriptors * be sure to close file instead of waiting for GC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #94 .
Why does this PR exist?
Running
GeneratePieceCommitmentin a loop can occasionally produce (depending on the quantity of iterations) atoo many open fileserror.What's in this PR?
In Go, the file descriptor associated with an
*os.Fileis cleaned up when the file is closed or when the*os.Fileis garbage collected. This changeset adds an explicitFile#Closecall instead of relying on garbage collection to free the file descriptor. When run in a loop, this keeps the file descriptor list at a constant size.