Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: read the correct number of bytes for the piece #17

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Aug 5, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@1b7ad32). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #17   +/-   ##
=========================================
  Coverage          ?   78.01%           
=========================================
  Files             ?        4           
  Lines             ?      191           
  Branches          ?        0           
=========================================
  Hits              ?      149           
  Misses            ?       27           
  Partials          ?       15           
Files Coverage Δ
commp.go 57.89% <100.00%> (ø)
writer/writer.go 90.32% <ø> (ø)

Copy link

github-actions bot commented Aug 5, 2024

Suggested version: 2.0.1

Comparing to: v2.0.0 (diff)

Changes in configuration file(s):

(empty)

gorelease says:

# summary
Suggested version: v2.0.1

gocompat says:

HEAD is now at 1b7ad32 chore: update deps, add dependabot
Switched to branch 'master'
Your branch is up to date with 'origin/master'.

Cutting a Release (and modifying non-markdown files)

This PR is modifying both version.json and non-markdown files.
The Release Checker is not able to analyse files that are not checked in to master. This might cause the above analysis to be inaccurate.
Please consider performing all the code changes in a separate PR before cutting the release.

Automatically created GitHub Release

A draft GitHub Release has been created.
It is going to be published when this PR is merged.
You can modify its' body to include any release notes you wish to include with the release.

Copy link
Contributor

@ribasushi ribasushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this looks identical to the original behavior of https://github.com/filecoin-project/go-commp-utils/blob/v0.1.4/ffiwrapper/ffiwrapper.go#L40-L54

Unsure if worth retracting 2.0.0 over this - fine either way.

Apologies I missed this eaerlier

@rvagg rvagg merged commit 11777d3 into master Aug 5, 2024
11 checks passed
@rvagg rvagg deleted the rvagg/eof branch August 5, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants