Fix UseStore for restarts #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahhoward
force-pushed
the
feat/fix-store-issues
branch
2 times, most recently
from
3ae360b
to
37c1126
Compare
hannahhoward
force-pushed
the
feat/fix-store-issues
branch
from
37c1126
to
c266cf0
Compare
hannahhoward
force-pushed
the
feat/fix-store-issues
branch
from
c266cf0
to
7f560ca
Compare
This was referenced Dec 1, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Fix UseStore in the case when a request is restarted -- sometimes this produces an error that causes a failure to use a custom store.
Implementation
Unregister any existing stores when restarting.