Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add logging to push channel monitor #131

Merged
merged 2 commits into from
Jan 14, 2021
Merged

add logging to push channel monitor #131

merged 2 commits into from
Jan 14, 2021

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Jan 14, 2021

No description provided.

@dirkmc dirkmc requested a review from nonsense January 14, 2021 14:20
@nonsense
Copy link
Member

lgtm, i'd only also add a log line at the beginning of func (mc *monitoredChannel) checkDataRate() { with mc.chid, so that we know this is also called (also we won't have so many data channels, so probably won't be spammy.

@dirkmc dirkmc merged commit 4998765 into master Jan 14, 2021
@dirkmc dirkmc deleted the feat/push-chan-logging branch January 14, 2021 15:17
This was referenced Jan 14, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nonsense nonsense nonsense approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dirkmc @nonsense