Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add config options to enable / disable push or pull monitoring individually #174

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Mar 24, 2021

Fixes #173

@dirkmc dirkmc force-pushed the feat/chan-mon-cfg-enable-pull-push branch from 5c3308f to e6444e5 Compare March 24, 2021 11:58
@@ -550,7 +558,7 @@ func TestChannelMonitorTimeouts(t *testing.T) {
mch := m.AddPushChannel(ch1).(*monitoredPushChannel)
chCtx = mch.ctx
} else {
mch := m.AddPushChannel(ch1).(*monitoredPushChannel)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did that work before?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It didn't 😆
It tests the right thing now and still works so that's good news 🎉

@dirkmc dirkmc merged commit 60ff921 into master Mar 24, 2021
@dirkmc dirkmc deleted the feat/chan-mon-cfg-enable-pull-push branch March 24, 2021 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add config to enable / disable data-rate monitoring for push and pull channels
2 participants