Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing CID Lists Part 2: Deprecating protocols #293

Merged
merged 3 commits into from
Jan 14, 2022

Conversation

hannahhoward
Copy link
Collaborator

Goals

Remove a whole lot of unused code for releases that no running filecoin node will need to support

Implementation

  • remove cid sets
  • remove cid lists
  • remove message 1_0 and associated graphsync extensions

@hannahhoward hannahhoward changed the base branch from master to feat/remove-cid-lists-sender January 14, 2022 06:28
Copy link
Contributor

@dirkmc dirkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🎉

@hannahhoward hannahhoward changed the base branch from feat/remove-cid-lists-sender to master January 14, 2022 22:45
@codecov-commenter
Copy link

Codecov Report

Merging #293 (85b4764) into master (7def500) will decrease coverage by 0.48%.
The diff coverage is 87.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #293      +/-   ##
==========================================
- Coverage   68.15%   67.67%   -0.49%     
==========================================
  Files          25       24       -1     
  Lines        3344     3186     -158     
==========================================
- Hits         2279     2156     -123     
+ Misses        695      683      -12     
+ Partials      370      347      -23     
Impacted Files Coverage Δ
channels/channels_fsm.go 68.23% <72.72%> (-0.19%) ⬇️
channels/block_index_cache.go 80.00% <80.00%> (ø)
channels/channels.go 72.72% <83.33%> (-0.34%) ⬇️
transport/graphsync/graphsync.go 76.41% <90.90%> (+0.50%) ⬆️
channels/channel_state.go 80.85% <100.00%> (+4.80%) ⬆️
impl/events.go 77.21% <100.00%> (+1.74%) ⬆️
impl/impl.go 64.94% <100.00%> (-0.48%) ⬇️
message/message1_1/transfer_request.go 69.49% <100.00%> (-8.89%) ⬇️
message/message1_1/transfer_response.go 90.24% <100.00%> (-5.99%) ⬇️
network/libp2p_impl.go 66.47% <100.00%> (+1.52%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eddbf61...85b4764. Read the comment docs.

@hannahhoward hannahhoward merged commit a12f639 into master Jan 14, 2022
zl03jsj added a commit to filecoin-project/venus that referenced this pull request Apr 20, 2022
go-data-transfer(filecoin-project/go-data-transfer#293),
it's dir is no longer needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants