-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The new data transfer #55
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add send voucher function to data transfer, and create update options for send & receive
add utilties to channel state and extract integration tests
add a pause attribute message
Setup pull requests to immediately send a GS request
Move all transport specific actions outside of the manage, into a transport layer than abstracts the underlying transport medium
track channel status, add new events and statuses and move start/stop out of constructor
refactor receiver to use transport to handle responses
Conver Channel to cbor-gen type
Refactor channels to use FSM, so we can track statuses and publish events automatically
also add some voucher result processing. this includes a major refactor of the testing strategy for the implementation to be more of a unit test
Complete implementation of data transfer pause and resume
Modify voucher validation to support pauses on first validate
add the final step for a retrieval flow -- being able to stop and start via vouchers
support connection tagging to protect connections from getting dropped
Split up functions into files so that they group better
hannahhoward
force-pushed
the
feat/the-new-data-transfer
branch
2 times, most recently
from
July 7, 2020 15:57
39f3e94
to
7b44091
Compare
hannahhoward
force-pushed
the
feat/the-new-data-transfer
branch
from
July 7, 2020 16:42
7b44091
to
466695d
Compare
switch integration test to table test to make sure not to reuse constructs taht are already in use
Only resume transport when it's possible for the transport to be resumed
ingar
approved these changes
Jul 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 as per our discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Support many things in data transfer, including:
Implementation
There are a number of changes here, but the basic architecture decisions are: