Investigate sensitivity to latency in multi instance tests #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assert that when latency seed is changed the tests passes eventually. In this case, it looks like the change in latency results in few additional rounds for the test to pass; 21 to be precise. Increase the max rounds to 30 in order to avoid intermittent errors during dev work that might change latency seeds. Closes #189
Kubuxu
approved these changes
May 3, 2024
|
I'm wondering if such behaviour also exists in other places but now it won't be a mystery (at least for me). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assert that when latency seed is changed the tests passes eventually. In this case, it looks like the change in latency results in few additional rounds for the test to pass; 21 to be precise.
Increase the max rounds to 30 in order to avoid intermittent errors during dev work that might change latency seeds.
Closes #189