Shortcut timeout in PREPARE when outcome is determined #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anorth I would love your early feedback on this please 🙏 |
anorth
reviewed
May 30, 2024
There was a problem hiding this comment.
The changes to tryPrepare/Commit look right to me.
These will be hard to cover with sim tests, but we should endeavour to cover them with unit tests of participant/instance #9 (won't affect line coverage, which is too crude for us here).
masih
force-pushed
the
masih/timeout-shortcut
branch
4 times, most recently
from
5f4b29e to
696b632
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #289 +/- ##
==========================================
+ Coverage 84.90% 85.29% +0.39%
==========================================
Files 14 14
Lines 1477 1476 -1
==========================================
+ Hits 1254 1259 +5
+ Misses 139 136 -3
+ Partials 84 81 -3
|
anorth
changed the title
anorth
force-pushed
the
masih/timeout-shortcut
branch
from
1e8667b to
e4f24f9
Compare
anorth
approved these changes
Jun 7, 2024
anorth
reviewed
Jun 7, 2024
When sufficient justification is received do not wait for timeouts to expire in PREPARE phase. Part of #242
masih
force-pushed
the
masih/timeout-shortcut
branch
from
e4f24f9 to
518f739
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sufficient justification is received do not wait for timeouts to expire in PREPARE phase.
Part of #242