fix(retrievalmarket): fix lint errors

filecoin-project · Jan 8, 2020 · 8bfda46 · 8bfda46
1 parent 27813e5
commit 8bfda46
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 9 deletions.
diff --git a/retrievalmarket/impl/provider.go b/retrievalmarket/impl/provider.go
@@ -55,8 +55,8 @@ func NewProvider(paymentAddress address.Address, node retrievalmarket.RetrievalP
 }
 
 // Start begins listening for deals on the given host
-func (p *provider) Start() {
-	p.network.SetDelegate(p)
+func (p *provider) Start() error {
+	return p.network.SetDelegate(p)
 }
 
 // V0

diff --git a/retrievalmarket/impl/provider_test.go b/retrievalmarket/impl/provider_test.go
@@ -45,15 +45,16 @@ func TestHandleQueryStream(t *testing.T) {
 		c := retrievalimpl.NewProvider(expectedAddress, node, net)
 		c.SetPricePerByte(expectedPricePerByte)
 		c.SetPaymentInterval(expectedPaymentInterval, expectedPaymentIntervalIncrease)
-		c.Start()
+		_ = c.Start()
 		net.ReceiveQueryStream(qs)
 	}
 
 	t.Run("it works", func(t *testing.T) {
 		qs := readWriteQueryStream()
-		qs.WriteQuery(retrievalmarket.Query{
+		err := qs.WriteQuery(retrievalmarket.Query{
 			PieceCID: pcid,
 		})
+		require.NoError(t, err)
 		node := newTestRetrievalProviderNode()
 		node.expectPiece(pcid, expectedSize)
 
@@ -72,9 +73,10 @@ func TestHandleQueryStream(t *testing.T) {
 
 	t.Run("piece not found", func(t *testing.T) {
 		qs := readWriteQueryStream()
-		qs.WriteQuery(retrievalmarket.Query{
+		err := qs.WriteQuery(retrievalmarket.Query{
 			PieceCID: pcid,
 		})
+		require.NoError(t, err)
 		node := newTestRetrievalProviderNode()
 		node.expectMissingPiece(pcid)
 
@@ -92,9 +94,10 @@ func TestHandleQueryStream(t *testing.T) {
 
 	t.Run("error reading piece", func(t *testing.T) {
 		qs := readWriteQueryStream()
-		qs.WriteQuery(retrievalmarket.Query{
+		err := qs.WriteQuery(retrievalmarket.Query{
 			PieceCID: pcid,
 		})
+		require.NoError(t, err)
 		node := newTestRetrievalProviderNode()
 
 		receiveStreamOnProvider(qs, node)
@@ -125,10 +128,10 @@ func TestHandleQueryStream(t *testing.T) {
 			Writer:     qWrite,
 			RespWriter: tut.FailResponseWriter,
 		})
-		qs.WriteQuery(retrievalmarket.Query{
+		err := qs.WriteQuery(retrievalmarket.Query{
 			PieceCID: pcid,
 		})
-
+		require.NoError(t, err)
 		node := newTestRetrievalProviderNode()
 		node.expectPiece(pcid, expectedSize)
 

diff --git a/retrievalmarket/types.go b/retrievalmarket/types.go
@@ -160,7 +160,7 @@ type ProviderSubscriber func(event ProviderEvent, state ProviderDealState)
 // retrieval operations and monitors deals received and process
 type RetrievalProvider interface {
 	// Start begins listening for deals on the given host
-	Start()
+	Start() error
 
 	// V0
 
@@ -251,6 +251,7 @@ type Query struct {
 	// QueryParams        // V1
 }
 
+// QueryUndefined is a query with no values
 var QueryUndefined = Query{}
 
 // NewQueryV0 creates a V0 query (which only specifies a piece)