Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provider Rejects Verified Deals At Proposal Time #286

Closed
hannahhoward opened this issue Jun 23, 2020 · 0 comments · Fixed by #307
Closed

Provider Rejects Verified Deals At Proposal Time #286

hannahhoward opened this issue Jun 23, 2020 · 0 comments · Fixed by #307
Assignees
@ingar
Milestone
Feature Freeze

Comments

@hannahhoward
Copy link
Collaborator

hannahhoward commented Jun 23, 2020 •
edited
Loading

As a provider, I want to reject a storage deal at the time it's proposed if VerifiedDeal is requested but the client is not verified or has exceeded it's data cap.

Steps:

  • Add method to StorageProviderNode - `GetDataCap(ctx context.Context, address.Address, tok shared.TipSetKey) (verifreg.DataCap, error)
  • When validating a deal proposal in the provider:
    • if VerifiedDeal = true on deal proposal
      • Call GetDataCap method with client address
      • if err != nil, reject deal (most likely client not verified)
      • if DataCap < deal piecesize, reject deal
@hannahhoward hannahhoward added the needs definition placeholder issue that needs further definition before it can be worked on label Jun 23, 2020
@hannahhoward hannahhoward changed the title Verified Client checking? Provider Rejects Verified Deals At Proposal Time Jun 24, 2020
@hannahhoward hannahhoward removed the needs definition placeholder issue that needs further definition before it can be worked on label Jun 24, 2020
@hannahhoward hannahhoward added this to the Feature Freeze milestone Jun 24, 2020
@ingar ingar mentioned this issue Jul 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ingar ingar

Labels
None yet
Projects
None yet
Milestone
Feature Freeze
Development

Successfully merging a pull request may close this issue.

Validate client's DataCap for verified deals filecoin-project/go-fil-markets
2 participants
@ingar @hannahhoward