Validate client's DataCap for verified deals #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks done-ish -- is it done? |
ingar
force-pushed
the
feat/verified-deal-validation
branch
from
a5d35f6
to
b25ee9d
Compare
Codecov Report
@@ Coverage Diff @@
## master #307 +/- ##
==========================================
- Coverage 63.52% 63.52% -0.00%
==========================================
Files 41 41
Lines 2574 2582 +8
==========================================
+ Hits 1635 1640 +5
- Misses 818 820 +2
- Partials 121 122 +1
Continue to review full report at Codecov.
|
hannahhoward
force-pushed
the
feat/verified-deal-validation
branch
from
b25ee9d
to
2a40ef1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For verified deal proposals, reject the deal if the
verifreg.DataCapfor the client isn't large enough.Resolves #286