Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

take miner address as parameter #108

Merged
merged 1 commit into from
Feb 4, 2020

Conversation

acruikshank
Copy link
Contributor

Problem

storageimpl.NewProvider errors out when it is given a datastore that does not contain a 'miner-address' value. This is not documented and also not a great way to pass configuration around between components.

Solution

Make minerAddress a parameter to NewProvider so we do not need to retrieve it from the datastore.

Copy link
Collaborator

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha! +1 on that!

LGTM

@hannahhoward hannahhoward merged commit 87675b3 into master Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants