Storage market network abstraction #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahhoward
force-pushed
the
feat/storage-market-network-abstraction
branch
from
d5047db
to
1c2f98d
Compare
hannahhoward
force-pushed
the
feat/no-filestore-on-storage-client
branch
2 times, most recently
from
391c11b
to
0e847a5
Compare
hannahhoward
force-pushed
the
feat/storage-market-network-abstraction
branch
from
1c2f98d
to
6cdb000
Compare
hannahhoward
changed the base branch from
feat/no-filestore-on-storage-client
to
master
ingar
approved these changes
Feb 4, 2020
go.sum
Outdated
| @@ -74,6 +74,7 @@ github.com/filecoin-project/go-sectorbuilder v0.0.1 h1:yiLSEprWA1E43DFTSCXLSuCst | |||
| github.com/filecoin-project/go-sectorbuilder v0.0.1/go.mod h1:3OZ4E3B2OuwhJjtxR4r7hPU9bCfB+A+hm4alLEsaeDc= | |||
| github.com/filecoin-project/go-statestore v0.1.0 h1:t56reH59843TwXHkMcwyuayStBIiWBRilQjQ+5IiwdQ= | |||
| github.com/filecoin-project/go-statestore v0.1.0/go.mod h1:LFc9hD+fRxPqiHiaqUEZOinUJB4WARkRfNl10O7kTnI= | |||
| github.com/filecoin-project/lotus v0.2.7 h1:kMroa4l/F3fcQp1s0T4wIhV0w0RZ6PPeFioXb3Mpwkw= | |||
There was a problem hiding this comment.
I believe that was fixed after mod tidy -- sorry
| @@ -26,7 +26,7 @@ func (c *Client) failDeal(id cid.Cid, cerr error) { | |||
|
|
|||
| s, ok := c.conns[id] | |||
| if ok { | |||
| _ = s.Reset() | |||
| _ = s.Close() | |||
There was a problem hiding this comment.
Close() is different than Reset(). Does it make sense to just close our end of the connection?
There was a problem hiding this comment.
It should end the connection on a failed deal
build an abstraction layer for communicating with the network over storage protocols
Replace direct references to libp2p host with network abstraction layer in client and provider
hannahhoward
force-pushed
the
feat/storage-market-network-abstraction
branch
from
6cdb000
to
8833819
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Abstract away underlying libp2p connections within the storage market, so that we can test the modules more easily
Implementation