Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send state identifiery when getting miner worker address #153

Merged
merged 3 commits into from
Mar 17, 2020

Conversation

laser
Copy link
Contributor

@laser laser commented Mar 17, 2020

Makes incremental progress towards #148.

@codecov-io
Copy link

codecov-io commented Mar 17, 2020

Codecov Report

Merging #153 into master will decrease coverage by 0.31%.
The diff coverage is 61.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
- Coverage   82.07%   81.76%   -0.30%     
==========================================
  Files          33       33              
  Lines        1561     1573      +12     
==========================================
+ Hits         1281     1286       +5     
- Misses        200      204       +4     
- Partials       80       83       +3     
Impacted Files Coverage Δ
storagemarket/types.go 100.00% <ø> (ø)
retrievalmarket/impl/provider.go 70.67% <50.00%> (-1.05%) ⬇️
...oragemarket/impl/providerstates/provider_states.go 95.78% <50.00%> (-1.34%) ⬇️
storagemarket/impl/storedask/storedask.go 79.73% <66.67%> (-1.69%) ⬇️
storagemarket/impl/providerutils/providerutils.go 88.24% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b4d091...82d76dd. Read the comment docs.

Copy link
Collaborator

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but two comments I'm hoping you can answer before you hit that merge button...

  • does an address lookup really change based on the TipSet key?
  • just curious -- why the method rename?

@laser
Copy link
Contributor Author

laser commented Mar 17, 2020

does an address lookup really change based on the TipSet key?

Yep, see here. A storage miner actor's worker address may be X at block height H and X' at H'. Passing the tipset key allows disambiguation when chain queries from the provider span multiple chain heads.

just curious -- why the method rename?

I changed the method name to match what's in go-storage-miner. I could change what's in go-storage-miner to match what's in go-fil-markets, I suppose - but I'm already making edits to this codebase. What do you prefer?

@laser
Copy link
Contributor Author

laser commented Mar 17, 2020

Oops. I linked to the wrong part of specs-actors. See this link for more info.

@hannahhoward
Copy link
Collaborator

all good! LGTM

@laser laser merged commit 47d1356 into master Mar 17, 2020
@laser laser deleted the feat/send-state-identifiery-get-miner-worker-address branch March 17, 2020 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants