Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TipSetToken to SavePaymentVoucher #165

Merged
merged 1 commit into from
Mar 18, 2020

Conversation

laser
Copy link
Contributor

@laser laser commented Mar 18, 2020

Why does this PR exist?

Implementations of the SavePaymentVoucher will need to inspect payment channel actor state in order to load the payment channel parties. It has historically used the chain head (implicitly) but should accept a tipset identifier.

@laser laser requested a review from hannahhoward March 18, 2020 01:24
Copy link
Collaborator

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM by me

@hannahhoward hannahhoward merged commit 6403a5b into master Mar 18, 2020
@laser laser deleted the bugs/save-payment-voucher-needs-token branch March 18, 2020 01:31
@dirkmc dirkmc mentioned this pull request Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants