Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename list deals interface & impls #174

Merged
merged 3 commits into from
Apr 1, 2020

Conversation

shannonwells
Copy link
Contributor

Closes #173, Cleanup: Rename ListInProgressDeals, ListIncompleteDeals to ListLocalDeals

Rename StorageClient.ListInProgressDeals -> StorageClient.ListLocalDeals
Rename StorageProvider.ListIncompleteDeals -> StorageProvider.ListLocalDeals
Change in implementations and get tests passing as needed

@shannonwells shannonwells marked this pull request as ready for review March 31, 2020 22:48
Copy link
Collaborator

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eeek should have included GetInProgressDeal on the client... my bad

storagemarket/types.go Outdated Show resolved Hide resolved
@codecov-io
Copy link

Codecov Report

Merging #174 into master will increase coverage by 0.16%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
+ Coverage   68.40%   68.55%   +0.16%     
==========================================
  Files          36       36              
  Lines        1987     1987              
==========================================
+ Hits         1359     1362       +3     
+ Misses        530      528       -2     
+ Partials       98       97       -1     
Impacted Files Coverage Δ
storagemarket/impl/client.go 0.00% <0.00%> (ø)
storagemarket/impl/provider.go 6.99% <0.00%> (ø)
storagemarket/types.go 100.00% <ø> (ø)
retrievalmarket/impl/blockio/traverser.go 74.12% <0.00%> (+3.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a845406...2c3f999. Read the comment docs.

@hannahhoward hannahhoward merged commit 6f76036 into master Apr 1, 2020
@shannonwells shannonwells deleted the techdebt/list-deals-rename-#173 branch April 3, 2020 23:12
@dirkmc dirkmc mentioned this pull request Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup: Rename ListInProgressDeals, ListIncompleteDeals to ListLocalDeals
3 participants