Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Selector to retrieval params #175

Merged
merged 4 commits into from
Apr 7, 2020
Merged

Conversation

ingar
Copy link
Contributor

@ingar ingar commented Apr 1, 2020

Summary

Adds selector to retrieval parameters V1.

Resolves #168

@codecov-io
Copy link

Codecov Report

Merging #175 into master will decrease coverage by 0.73%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
- Coverage   68.61%   67.89%   -0.72%     
==========================================
  Files          37       38       +1     
  Lines        1991     2024      +33     
==========================================
+ Hits         1366     1374       +8     
- Misses        528      552      +24     
- Partials       97       98       +1     
Impacted Files Coverage Δ
retrievalmarket/types.go 24.25% <80.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 473c5d1...efbb7b0. Read the comment docs.

@ingar ingar marked this pull request as ready for review April 6, 2020 20:47
@ingar ingar requested a review from hannahhoward April 6, 2020 20:48
@hannahhoward hannahhoward merged commit b8b9af5 into master Apr 7, 2020
@ingar ingar deleted the feat/selectors-retrieval branch April 20, 2020 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selectors Are Part Of Retrieval Deal Proposal
3 participants