For a storage deal proposal that is rejected, include rejection reason in client response #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #182 +/- ##
=======================================
Coverage 68.61% 68.61%
=======================================
Files 37 37
Lines 1991 1991
=======================================
Hits 1366 1366
Misses 528 528
Partials 97 97
Continue to review full report at Codecov.
|
shannonwells
commented
Apr 4, 2020
| Action(func(deal *storagemarket.ClientDeal, state storagemarket.StorageDealStatus) error { | ||
| deal.Message = xerrors.Errorf("deal wasn't accepted (State=%d)", state).Error() | ||
| Action(func(deal *storagemarket.ClientDeal, state storagemarket.StorageDealStatus, reason string) error { | ||
| deal.Message = xerrors.Errorf("deal failed: (State=%d) %s", state, reason).Error() |
There was a problem hiding this comment.
Changed this because "deal rejected" is already in the message and the status itself is storagemarket.StorageDealFailing
hannahhoward
approved these changes
Apr 6, 2020
| Action(func(deal *storagemarket.ClientDeal, state storagemarket.StorageDealStatus) error { | ||
| deal.Message = xerrors.Errorf("deal wasn't accepted (State=%d)", state).Error() | ||
| Action(func(deal *storagemarket.ClientDeal, state storagemarket.StorageDealStatus, reason string) error { | ||
| deal.Message = xerrors.Errorf("deal failed: (State=%d) %s", state, reason).Error() |
shannonwells
force-pushed
the
feat/sm-client-sees-err-#176
branch
from
64b3dfb
to
43e4b9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #176