Piece IO #2
Merged
Piece IO #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define API and interfaces for pieceIO component
hannahhoward
approved these changes
Dec 11, 2019
There was a problem hiding this comment.
@ergastic this looks good generally. I think we should remove the WritePayload function from the Interface & implementation cause it doesn't appear to do anything GeneratePieceCommitment doesn't, and the current implementation doesn't do that.
Keep working on this if you want till you go on storage miner and then we'll just pick it up.
| tempDir filestore.Path | ||
| } | ||
|
|
||
| func NewPieceIO(padReader PadReader, carIO CarIO, sectorCalculator SectorCalculator, tempDir filestore.Path) PieceIO { |
There was a problem hiding this comment.
I wonder -- should PieceIO just have access to a Filestore directly and be called a PieceStore? And then we don't have to worry about getting things in and out of the filestore?
There was a problem hiding this comment.
In that case I'd like add a function to create a temporary file through the filestore.
laser
added a commit
that referenced
this pull request
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
filecoin-ffiPending
Better unit test coverage